fix: delete file lost wake #1323
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
commented
May 13, 2025
Comment on lines
-208
to
-215
| match self.state.try_read() { | ||
| Ok(guard) => match guard.deref() { | ||
| DeleteFileIndexState::Populated(idx) => Poll::Ready(Ok( | ||
| idx.get_deletes_for_data_file(self.data_file, self.seq_num) | ||
| )), | ||
| _ => Poll::Pending, | ||
| }, | ||
| Err(err) => Poll::Ready(Err(Error::new(ErrorKind::Unexpected, err.to_string()))), |
There was a problem hiding this comment.
We have 2 possible problems here:
try_readreturnsTryLockError::WouldBlock, which should not be an error, butPending.- More severely, we don't have any
Wakerset, so oncePending, the future will sleep forever.
Therefore, I think it's better to replace manual Future implementation with other sync primitives.
There was a problem hiding this comment.
I've addressed the missing Waker in my open PR in my open PR: 5f0b073
There was a problem hiding this comment.
which PR？
BTW, it seems in this commit the TryLock problem is not resolved
There was a problem hiding this comment.
BTW, I think manual Future implementation should be discouraged in favor of async fn with synchronisation primitives.
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
xxchan/increased-wolf
branch
from
abb3e65 to
596dc07
Compare
Signed-off-by: xxchan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Fix bug caused in #652
For detail see inline comments
Are these changes tested?